tests: update tests #712
Merged
tests: update tests #712
+18
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here I'm updating tests with recent changes to the test generator: - adding tests for `blockHash` parameter of eth_getLogs - testing more parameter error cases of eth_getLogs - fixing the error code of eth_getStorageAt for invalid parameter - fixing the transaction type in eth_estimateGas test with blobs
taratorio
added a commit
to erigontech/erigon
that referenced
this pull request
Dec 5, 2025
this fixes our Hive rpc-compat CI failure which surfaced today - not due to our regression - but due to some new eth_getLogs tests that have been added and some eth_getStorageAt and eth_estimateGas tests that have been updated in ethereum/execution-apis#712 increasing the allowed failures to 12 to make our CI green for the short term added an issue to fix these new failures #18181
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I'm updating tests with recent changes to the test generator:
blockHashparameter of eth_getLogs